Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle ASCII decoding exceptions #143

Merged
merged 3 commits into from
Jun 23, 2018
Merged

Gracefully handle ASCII decoding exceptions #143

merged 3 commits into from
Jun 23, 2018

Conversation

edeca
Copy link

@edeca edeca commented Apr 4, 2018

Fix #142

@edeca
Copy link
Author

edeca commented Apr 4, 2018

Build appears to be failing due to test cases binding ::1 inside Travis.

@waynew
Copy link
Collaborator

waynew commented Jun 9, 2018

Hey @edeca can you try this fix - add this to .travis.yaml:

before_script:
  - echo 0 | sudo tee /proc/sys/net/ipv6/conf/all/disable_ipv6

Also it looks like it's missing some code coverage on appveyor:

py35-cov runtests: commands[3] | python -m coverage report -m --rcfile=C:\projects\aiosmtpd/.coverage.ini --fail-under=100
Name                        Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------
aiosmtpd\__init__.py            0      0      0      0   100%
aiosmtpd\controller.py         50      0      6      0   100%
aiosmtpd\docs\__init__.py       0      0      0      0   100%
aiosmtpd\handlers.py          143      0     50      0   100%
aiosmtpd\lmtp.py               11      0      2      0   100%
aiosmtpd\main.py               74      0     14      0   100%
aiosmtpd\smtp.py              494      6    186      0    99%   239-241, 247-249
-----------------------------------------------------------------------
TOTAL                         772      6    258      0    99%
ERROR: InvocationError for command 'C:\\projects\\aiosmtpd\\.tox\\py35-cov\\Scripts\\python.EXE -m coverage report -m --rcfile=C:\\projects\\aiosmtpd/.coverage.ini --fail-under=100' (exited with code 2)

@edeca
Copy link
Author

edeca commented Jun 9, 2018

Test cases now cover both exception handlers and Travis is fixed.

@waynew
Copy link
Collaborator

waynew commented Jun 16, 2018

Awesome. AFAICT this looks like a good thing 👍

@waynew waynew merged commit ec804d9 into aio-libs:master Jun 23, 2018
@waynew waynew added this to the 1.2 milestone Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants