initial stream monitor concept #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,12 +126,15 @@ def __init__(self, loop, *, high=None, low=None): | |||
| self._protocol = ZmqStreamProtocol(self, loop=loop) | |||
| self._loop = loop | |||
| self._queue = collections.deque() | |||
| self._event_queue = collections.deque() | |||
There was a problem hiding this comment.
Please add constructor parameter for managing _event_queue size.
I guess default should be big enough -- say, 100 events (which is not too big for taking care about memory consumption). None is not allowed -- I'd like to reserve None for adding flow control later if needed.
|
I've finished the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial concept for exposing the monitor capability with streams. What do you think?
Obviously lots of tests, docs updates would follow but does this look like a useful approach?