Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply wraps the
disable_monitor
coroutine in aasyncio.Task
to ensure it is run.This change fixes the test failures observed. With the recent change to convert
disable_monitor
to a coroutine some of the monitor related tests no longer pass. However, this is not observed on Travis CI because it uses alibzmq
andpyzmq
combination that do not support the socket monitor capability - which in turn results inaiozmq
monitor tests being skipped.One strategy that might be worth considering in this area would be to use
asyncio.gather
to accumulate intermediate futures and then callconnection_lost
once thegather
future fires. This would avoid the potential for race conditions of callingself._loop.call_soon(self.call_connection_lost, None)
before any prior async functions complete.