Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/task/bug] GHA check job misconfiguration #327

Closed
webknjaz opened this issue Sep 22, 2022 · 0 comments · Fixed by #354
Closed

[CI/task/bug] GHA check job misconfiguration #327

webknjaz opened this issue Sep 22, 2022 · 0 comments · Fixed by #354
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@webknjaz
Copy link
Member

As it is configured now, the test-summary job will always pass in the branch protection rules because it'll either be green (success) or gray (skip — this happens when the tests fail) which is ultimately interpreted as “not failing”.

The fix is easy — use if: always(). And it's better to use https://github.com/re-actors/alls-green, since all the detection logic is generalized well there.

@webknjaz webknjaz added bug Something isn't working good first issue Good for newcomers labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant