CI: detect test matrix failure correctly #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing always(), and use the alls-green action to verify the status of the test matrix jobs. Without always() the check step was being skipped whenever a test failed. 🤦
mjpieters
force-pushed
the
ci_test_success_check
branch
from
768c944
to
eedc25d
Compare
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 1 1
Lines 61 61
Branches 9 9
=======================================
Hits 60 60
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing
always(), and use the alls-green action to verify the status of the test matrix jobs. Withoutalways()the check step was being skipped whenever a test failed. 🤦Fixes #327