Fix version regex for multi-line version files #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 75.00%
=========================================
Files ? 1
Lines ? 136
Branches ? 30
=========================================
Hits ? 102
Misses ? 28
Partials ? 6
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Why is there a Python version test matrix when the action only ever runs on 3.10? |
|
The pre-commit-based lint step also looks redundant (apart from the fact that it fails because it uses a |
|
I rebased this onto #37 so the CI steps at least pass. |
|
@asvetlov Pokedipoke. Any chance this can get reviewed and merged? |
1 task
- Expand version tests to use a multi-line mock-module text as base. - Add a test with matching quote following version string to verify the backref is working correctly. - add `re.MULTILINE` flag so `^` matches right after a newline, not just the start of the text. - Use a negative lookahead assertion against the backref, instead of a backref inside a character class. Character classes don't support backrefs. - Use `.search()` instead of `.match()`; we need to find the pattern anywhere in the version file, not just the start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The version regex has several issues, primarily because it assumes the version file consists of a single line. This broke the Yarl 1.8 release; this PR fixes the issue.
correctly.
re.MULTILINEflag so^matches right after a newline, not just thestart of the text.
inside a character class. Character classes don't support backrefs.
.search()instead of.match(); we need to find the pattern anywherein the version file, not just the start.
INPUT_CHECK_REFenv var toruns:section.Checklist