Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multidict[int] for pure-python version #678

Merged
merged 14 commits into from
Jan 22, 2022
Merged

Conversation

asvetlov
Copy link
Member

__class_getitem__ is already provided by C Extension, making it work with the pure-extension too.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #678 (0072061) into master (0e0e98f) will decrease coverage by 0.12%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   93.77%   93.65%   -0.13%     
==========================================
  Files           5        5              
  Lines         498      504       +6     
==========================================
+ Hits          467      472       +5     
- Misses         31       32       +1     
Impacted Files Coverage Δ
multidict/_multidict_py.py 99.12% <83.33%> (-0.29%) ⬇️
multidict/__init__.py 100.00% <100.00%> (ø)
multidict/_compat.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0e98f...0072061. Read the comment docs.

@asvetlov asvetlov merged commit 4a2a553 into master Jan 22, 2022
@asvetlov asvetlov deleted the class_getitem branch January 22, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant