Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests compatible with PyPy3.5-5.8.0 #152

Merged
merged 14 commits into from
Oct 2, 2017

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Oct 1, 2017

No description provided.

@webknjaz webknjaz self-assigned this Oct 1, 2017
@webknjaz webknjaz requested a review from asvetlov October 1, 2017 19:17
@webknjaz webknjaz force-pushed the feature/run-tests-against-pypy3.5 branch from 1f05a18 to 4a62d93 Compare October 1, 2017 19:19
@webknjaz webknjaz force-pushed the feature/run-tests-against-pypy3.5 branch from 4a62d93 to 067f974 Compare October 1, 2017 19:44
@codecov
Copy link

codecov bot commented Oct 1, 2017

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #152   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines         302    307    +5     
=====================================
+ Hits          302    307    +5
Impacted Files Coverage Δ
multidict/_compat.py 100% <100%> (ø)
multidict/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d84e53...067f974. Read the comment docs.

@webknjaz webknjaz changed the title WIP: Make tests compatible with PyPy3.5-5.8.0 Make tests compatible with PyPy3.5-5.8.0 Oct 1, 2017
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ids=['MultiDict', 'PyMultiDict',
'CIMultiDict', 'PyCIMultiDict'])
@pytest.fixture(
params=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer more dense formatting but can live with your notation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked less maintainable and less readable to me when it was dense.

@asvetlov asvetlov merged commit 6e8f82a into master Oct 2, 2017
@asvetlov asvetlov deleted the feature/run-tests-against-pypy3.5 branch October 2, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants