Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy 0.620 and generic type aliases #272

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Mypy 0.620 and generic type aliases #272

merged 3 commits into from
Jul 31, 2018

Commits on Jul 27, 2018

  1. tox.ini: Use upgrade mypy 0.620

    @tailhook
    tailhook committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    63721e8 View commit details
    Browse the repository at this point in the history

  2. Fix usage of generic type aliases 

    If disallow_any_generics is enabled, we get the following errors in
projects using multidict:

    multidict/__init__.pyi:34: error: Missing type parameters for generic type
    multidict/__init__.pyi:42: error: Missing type parameters for generic type
    multidict/__init__.pyi:58: error: Missing type parameters for generic type
    @tailhook
    tailhook committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    91a86ce View commit details
    Browse the repository at this point in the history

  3. Fix errors of mypy 0.620 

    Here are the original errors:

    multidict/__init__.pyi:16: error: Class multidict.MultiMapping has abstract attributes "__getitem__", "__iter__", "__len__"
    multidict/__init__.pyi:16: note: If it is meant to be abstract, add 'abc.ABCMeta' as an explicit metaclass
    multidict/__init__.pyi:28: error: Class multidict.MutableMultiMapping has abstract attributes "__delitem__", "__getitem__", "__iter__", "__len__", "__setitem__"
    multidict/__init__.pyi:28: note: If it is meant to be abstract, add 'abc.ABCMeta' as an explicit metaclass

Another things fixed:

* MultiDictProxy.copy returns MultiDict (not Proxy)
* CIMultiDictProxy.copy returns CIMultiDict (not Proxy)
    @tailhook
    tailhook committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    c6d1d61 View commit details
    Browse the repository at this point in the history