Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type annotations for keys of multidict mapping classes #677

Merged
merged 4 commits into from Jan 22, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Jan 19, 2022

ref:
python/mypy#8477

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Fixes #644

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@q0w q0w requested a review from asvetlov as a code owner January 19, 2022 07:42
@q0w q0w requested a review from webknjaz as a code owner January 19, 2022 08:13
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 19, 2022
@webknjaz
Copy link
Member

Could you fill out the PR title/description?

CHANGES/644.bugfix.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #677 (4613144) into master (1322f1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files           5        5           
  Lines         498      498           
=======================================
  Hits          467      467           
  Misses         31       31           
Flag Coverage Δ
unit 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1322f1a...4613144. Read the comment docs.

@asvetlov asvetlov changed the title Fix #644 Fixed type annotations for keys of multidict mapping classes Jan 22, 2022
@asvetlov asvetlov merged commit 48f29bd into aio-libs:master Jan 22, 2022
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIMultiDict has incompatible type Dict[istr, str]
3 participants