Fix setuptools warning: "multidict._multilib not in packages list" #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following build warning:
############################
# Package would be ignored #
############################
Python recognizes 'multidict._multilib' as an importable package,
but it is not listed in the `packages` configuration of setuptools.
'multidict._multilib' has been automatically added to the distribution only
because it may contain data files, but this behavior is likely to change
in future versions of setuptools (and therefore is considered deprecated).
Please make sure that 'multidict._multilib' is included as a package by using
the `packages` configuration field or the proper discovery methods
(for example by using `find_namespace_packages(...)`/`find_namespace:`
instead of `find_packages(...)`/`find:`).
You can read more about "package discovery" and "data files" on setuptools
documentation page.
webknjaz
reviewed
Dec 17, 2023
| @@ -80,7 +80,7 @@ def read(f): | |||
| "GitHub: repo": "https://github.com/aio-libs/multidict", | |||
| }, | |||
| license="Apache 2", | |||
| packages=["multidict"], | |||
| packages=["multidict", "multidict._multilib"], | |||
There was a problem hiding this comment.
It's not a package — it only contains C-headers. So I don't think it's correct to add it here. Perhaps, this needs to be addressed differently.
webknjaz
reviewed
Dec 27, 2023
| @@ -80,7 +80,7 @@ def read(f): | |||
| "GitHub: repo": "https://github.com/aio-libs/multidict", | |||
| }, | |||
| license="Apache 2", | |||
| packages=["multidict"], | |||
| packages=["multidict", "multidict._multilib"], | |||
| python_requires=">=3.7", | |||
| include_package_data=True, | |||
There was a problem hiding this comment.
I posted a question @ pypa/setuptools#3340 (comment), but it seems include_package_data=True should be re-assessed — do we need it enabled? Why? Would disabling it also remove the warning?
There was a problem hiding this comment.
I experimented with this and it turned out that removing the setting yields the same distribution contents while not emitting the warning so I've gone with that: 31e1170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following build warning: