Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix to URL.with_port() input filtering (#793)
* Handled case where update_query() is handed None as an argument. Added corresponding test file as well. * Added implementation and tests * Got rid of irrelevant test case for this branch * Cleanup * Readjusted to include 0 for ports (unsure if needed) * Create 793.bugfix.rst * Update 793.bugfix.rst Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
- Loading branch information
Showing
3 changed files
with
19 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added some input restrictions on with_port() function to prevent invalid boolean inputs or out of valid port inputs; handled incorrect 0 port representation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for urls created with
URL.build(…, port="")
this createsscheme://host:/