馃摝馃帹 Move package attrs to declarative config #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
This cleans up `setup.py`, keeping only things that are hard to move. It puts all possible attrs into `setup.cfg`. It doesn't attempt making use of `pyproject.toml` for this purpose because it's easier to maintain separate configs in dedicated files, on scale.
webknjaz
force-pushed
the
packaging/declarative-setup.cfg
branch
from
29a0bb3
to
97d0d37
Compare
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 4 4
Lines 772 772
Branches 219 219
=======================================
Hits 770 770
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
webknjaz
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up
setup.py, keeping only things that are hard to move. It puts all possible attrs intosetup.cfg. It doesn't attempt making use ofpyproject.tomlfor this purpose because it's easier to maintain separate configs in dedicated files, on scale.