Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦🎨 Move package attrs to declarative config #890

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

webknjaz
Copy link
Member

This cleans up setup.py, keeping only things that are hard to move. It puts all possible attrs into setup.cfg. It doesn't attempt making use of pyproject.toml for this purpose because it's easier to maintain separate configs in dedicated files, on scale.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 12, 2023
This cleans up `setup.py`, keeping only things that are hard to move.
It puts all possible attrs into `setup.cfg`. It doesn't attempt
making use of `pyproject.toml` for this purpose because it's easier to
maintain separate configs in dedicated files, on scale.
@webknjaz webknjaz force-pushed the packaging/declarative-setup.cfg branch from 29a0bb3 to 97d0d37 Compare June 12, 2023 22:33
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #890 (97d0d37) into master (fe9c47e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
  Branches      219      219           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz merged commit 4938032 into aio-libs:master Jun 12, 2023
webknjaz added a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant