Do not install C sources with binary distributions #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
This does not affect source distributions, and Cython sources (.pyx) are still installed. Fixes aio-libs#646.
musicinmybrain
force-pushed
the
c-sources
branch
from
ef6b5f7
to
b255657
Compare
asvetlov
approved these changes
Dec 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 4 4
Lines 739 739
Branches 168 168
=======================================
Hits 737 737
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not affect source distributions, and Cython sources (
.pyx) arestill installed.
Fixes #646.
What do these changes do?
Prevent C sources (
_quoting_c.c) from being included in binary distributions such as wheels, without affecting Cython sources (_quoting_c.pyx,_quoting_c.pyi) or source distributions.Are there changes in behavior for the user?
Nothing changes except that the binary wheels are smaller because they do not contain
_quoting_c.c.Related issue number
#646
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.