Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hints #891

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Update type hints #891

merged 1 commit into from
Jun 17, 2023

Conversation

mjpieters
Copy link
Contributor

  • explicit_port and __bytes__ were missing
  • joinpath() takes an optional encoded argument

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #891 (d61a106) into master (c20808a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
  Branches      219      219           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- `explicit_port` and `__bytes__` were missing
- `joinpath()` takes an optional `encoded` argument
@mjpieters
Copy link
Contributor Author

Preferably we detect these issues earlier, but with the current .pyi file I am not sure that that's possible. Moving the type hints into yarl/_url.py would make it possible to run mypy in strict mode and so catch missing type hints there, but that's a larger undertaking.

@mjpieters mjpieters merged commit 63dbf3e into master Jun 17, 2023
37 checks passed
@mjpieters mjpieters deleted the type_annotations branch June 17, 2023 18:28
@Julian Julian mentioned this pull request Aug 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant