Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new method for Router #1117

Merged
merged 6 commits into from Feb 11, 2023
Merged

add new method for Router #1117

merged 6 commits into from Feb 11, 2023

Conversation

sheldygg
Copy link
Contributor

@sheldygg sheldygg commented Feb 8, 2023

Description

Added a method that allows you to compactly register routers

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation (typos, code examples or any documentation update)

How has this been tested?

Type here...

Test Configuration

  • Operating system: Windows 10
  • Python version: 3.10.9

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@github-actions github-actions bot added the 3.x Issue or PR for upcoming 3.0 version label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@sheldygg sheldygg marked this pull request as ready for review February 8, 2023 17:22
aiogram/dispatcher/router.py Outdated Show resolved Hide resolved
tests/test_dispatcher/test_router.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1117 (9550f6a) into dev-3.x (e8d279c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          340       340           
  Lines         8829      8834    +5     
=========================================
+ Hits          8829      8834    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/router.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit bac90c8 into aiogram:dev-3.x Feb 11, 2023
@sheldygg sheldygg deleted the dev-3.x branch February 11, 2023 23:28
@sheldygg sheldygg restored the dev-3.x branch February 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for upcoming 3.0 version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants