Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing message content types #1252

Merged
merged 5 commits into from Aug 13, 2023
Merged

Fix missing message content types #1252

merged 5 commits into from Aug 13, 2023

Conversation

Forden
Copy link
Contributor

@Forden Forden commented Aug 8, 2023

Description

Telegram supports sharing users and chats through convenient UI since February, 2023 and while aiogram has support for user_shared and chat_shared params, it doesn't detect them in message.content_type helper. This PR fixes this error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should also be added.

CHANGES/1252.bugfix.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1252 (da082a0) into dev-3.x (4e7c667) will decrease coverage by 0.03%.
Report is 6 commits behind head on dev-3.x.
The diff coverage is 50.00%.

❗ Current head da082a0 differs from pull request most recent head 3e24d4d. Consider uploading reports for the commit 3e24d4d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           dev-3.x    #1252      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files          364      364              
  Lines         9309     9313       +4     
===========================================
+ Hits          9309     9311       +2     
- Misses           0        2       +2     
Flag Coverage Δ
unittests 99.97% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiogram/types/message.py 99.57% <50.00%> (-0.43%) ⬇️

Forden and others added 2 commits August 11, 2023 13:43
Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
@JrooTJunior JrooTJunior merged commit 4d12e07 into aiogram:dev-3.x Aug 13, 2023
8 of 20 checks passed
@Forden Forden deleted the Forden-patch-1 branch August 14, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants