Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeyboardButtonPollTypeType enum #1398

Merged
merged 2 commits into from Jan 27, 2024

Conversation

JrooTJunior
Copy link
Member

@JrooTJunior JrooTJunior commented Jan 27, 2024

A new enum KeyboardButtonPollTypeType for KeyboardButtonPollTypeType.type field has bed added.

A new enum, KeyboardButtonPollType, has been added and documented. This enum holds types of polls that can be created and sent when the corresponding button is pressed. It is now imported and included in the aiogram enums documentation.
@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Jan 27, 2024
Copy link

github-actions bot commented Jan 27, 2024

✔️ Changelog found.

Thank you for adding a description of the changes

@JrooTJunior JrooTJunior marked this pull request as ready for review January 27, 2024 15:28
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eeafe46) 100.00% compared to head (1e85083) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          410       411    +1     
  Lines        10603     10608    +5     
=========================================
+ Hits         10603     10608    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiogram/enums/__init__.py 100.00% <100.00%> (ø)
aiogram/enums/keyboard_button_poll_type_type.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit d3c6379 into dev-3.x Jan 27, 2024
23 checks passed
@SychO3
Copy link

SychO3 commented Feb 6, 2024

It should be KeyboardButtonPollType,The name seems to be wrong

@JrooTJunior
Copy link
Member Author

Object from the Bot API is named as KeyboardButtonPollType, but this pull request adds an enumeration of known poll types that can be passed into KeyboardButtonPollType.type field, so, the name of this enum is combination of object type name and field name - KeyboardButtonPollTypeType.

Names of the object should not be overlapped in the framework codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants