Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presign_url method, allow more aiohttp versions & py3.12 #29

Merged
merged 6 commits into from
May 7, 2024
Merged

Add presign_url method, allow more aiohttp versions & py3.12 #29

merged 6 commits into from
May 7, 2024

Conversation

alvassin
Copy link
Collaborator

@alvassin alvassin commented Mar 19, 2024 •
edited
Loading

  • Add presign_url method & tests
  • Remove 3.7 python support
  • Add 3.12 python support & setuptools dev dependency

@coveralls
Copy link

coveralls commented Mar 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8975944548

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.6%) to 93.117%
Files with Coverage Reduction New Missed Lines %
aiohttp_s3_client/xml.py 1 96.49%
aiohttp_s3_client/credentials.py 4 89.57%
aiohttp_s3_client/client.py 6 94.28%
Totals Coverage Status
Change from base Build 8570507630: 2.6%
Covered Lines: 487
Relevant Lines: 523
💛 - Coveralls

@dizballanze
Copy link
Member

Looks good. Just add some documentation to README.

@alvassin alvassin changed the title Add presign_url method Add presign_url method, allow more aiohttp versions Apr 30, 2024
@alvassin alvassin changed the title Add presign_url method, allow more aiohttp versions Add presign_url method, allow more aiohttp versions & py3.12 Apr 30, 2024
dizballanze
dizballanze reviewed May 2, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@alvassin alvassin force-pushed the master branch 2 times, most recently from 3255f23 to 12ca599 Compare May 6, 2024 20:38
@mosquito mosquito self-requested a review May 6, 2024 20:53
@alvassin alvassin force-pushed the master branch 2 times, most recently from fecbd83 to 73e3837 Compare May 6, 2024 21:13
@mosquito mosquito merged commit 15ac5b3 into aiokitchen:master May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosquito mosquito mosquito approved these changes

@dizballanze dizballanze dizballanze approved these changes

@leenr leenr leenr approved these changes

@Alviner Alviner Alviner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alvassin @coveralls @dizballanze @mosquito @leenr @Alviner