DB refactor to use new lookup tables #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors were due to the previous test DB being somewhat handmade and me being unable to reproduce it exactly. It's mostly sorted now, except for 2 tests, but it will probably be better to update the tests if I can't fix the test DB to match exactly what it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new lookup tables, there is no need at all for the token cache, which has been removed entirely. That had some downstream consequences for other areas that were using pointers to the cache, and those have all been resolved.
As of right now, the tests are mostly passing, the remaining errors seem to be some sort of ordering issue in candidate sorting.