Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libvpx to fix security vulnerability #9

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Oct 25, 2023

libxvpx prior to version 1.13.1 suffers from a buffer overflow vulnerability, see CVE-2023-5217.

@jlaine
Copy link
Contributor Author

jlaine commented Oct 25, 2023

NOTE: This only solves the problem for Linux and macOS. It does not solve the problem for Windows, as we are picking up binary builds from vcpkg which stills ships vpx 1.12.0.

Copy link

@fippo fippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the recommended fix! Let me check if I can find vcpkg folks...

@jlaine
Copy link
Contributor Author

jlaine commented Nov 9, 2023

That is the recommended fix! Let me check if I can find vcpkg folks...

I opened microsoft/vcpkg#34809 which has seen some activity but not been merged

@jlaine jlaine force-pushed the vpx-1.13.1 branch 4 times, most recently from fcc256b to 967c840 Compare November 21, 2023 19:57
@jlaine
Copy link
Contributor Author

jlaine commented Nov 23, 2023

The fix was merged over a week ago, but the package still seems stuck at version 1.12.0:

https://vcpkg.io/en/packages?query=libvpx

libxvpx prior to version 1.13.1 suffers from a buffer overflow
vulnerability, see CVE-2023-5217.
@jlaine jlaine merged commit d911a8e into aiortc:main Nov 30, 2023
7 checks passed
@jlaine jlaine deleted the vpx-1.13.1 branch November 30, 2023 15:35
@jlaine
Copy link
Contributor Author

jlaine commented Nov 30, 2023

vcpkg finally caught up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants