feat: require unique error details messages #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alin04
reviewed
May 8, 2023
alin04
approved these changes
May 9, 2023
AIP-193 expresses that for a certain message type, it must be unique in "details" on Status. That is there can be only one message of a certain type as an error detail. Fixes: aip-dev#1086
shwoodard
force-pushed
the
issue-1086-aip-193-details-type-uniqueness
branch
from
dc88be4
to
2cb3652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIP-193 expresses that for a certain message type, it must be unique in "details" on Status after the PR. That is there can be only one message of a certain type as an error detail.
Fixes: #1086