feat(AIP-203): require field behavior #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the likelihood of missed field behavior annotations, require it for all message feilds. further rationale is explained in the change of AIP-203.
toumorokoshi
force-pushed
the
toum/require-field-behavior
branch
from
9964ef3
to
cd1e331
Compare
bgrant0607
reviewed
May 11, 2023
- fix IMMUTABLE to OPTIONAL among required attributes.
bgrant0607
reviewed
May 11, 2023
clarifying that *all* field behavior annotations are required.
bgrant0607
approved these changes
May 11, 2023
shwoodard
requested changes
May 19, 2023
- message to "field"
- concise wording
shwoodard
requested changes
May 22, 2023
- linking to proto as the source-of-truth. - adding warning on field behavior compatibility.
shwoodard
approved these changes
May 23, 2023
toumorokoshi
added a commit
to googleapis/api-linter
that referenced
this pull request
May 25, 2023
Adding guidance from aip-dev/google.aip.dev#1100 removing optional_consistency, which is now redundant.
Hkoma95
approved these changes
May 21, 2024
Hkoma95
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the likelihood of missed field behavior annotations,
require it for all message feilds.
further rationale is explained in the change of AIP-203.