[AIP-132] Remove requirement to document ordering. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2020 13:17
googlebot
added
the
cla: yes
jskeet
reviewed
May 27, 2020
|
I think this falls into the category of "not actually needed". I can not find any API that actually documents this (I looked), and it seems to cause no user consternation. No API reviewer checks for this. We have no good enforcement mechanism since there is no machine-readable way to check, either. I prefer not have "dead law" -- if it is not being done, and it is not causing pain, and I do not intend to put any effort toward changing it, then I think it is better to be silent / permissive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally planned to add an example as the person who posted #506 suggested, but it turns out that literally nobody documents this. As best as I can tell, this has never been a problem for anyone, and therefore I believe we should just remove the requirement.
Fixes #506.