Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend restricting to lower-case for custom revision tags #707

Merged
merged 1 commit into from Mar 10, 2021
Merged

Recommend restricting to lower-case for custom revision tags #707

merged 1 commit into from Mar 10, 2021

Conversation

seaneganx
Copy link
Contributor

@seaneganx seaneganx commented Mar 8, 2021 •
edited

This change also updates the example to disallow hyphens as the last character in a custom tag. Resolves #702.

@seaneganx seaneganx requested a review from a team as a code owner March 8, 2021 22:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
lukesneeringer
lukesneeringer approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this.

@lukesneeringer lukesneeringer merged commit 463cfd0 into aip-dev:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-162 Should revision tagging be case insensitive?
2 participants
@seaneganx @lukesneeringer