Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception when replanner remove_{action/goal} fails #474

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Framba-Luca
Copy link
Contributor

Now the integrated meta-engine replanner does not silently fail when a remove_action or remove_goal does not change the problem.

@Framba-Luca Framba-Luca self-assigned this Aug 16, 2023
@Framba-Luca
Copy link
Contributor Author

Framba-Luca commented Aug 16, 2023

Thinking about this feature, we could insert a flag that determines if the user wants an exception when the method fails (default behavior) or he prefers a silent fail.

Issues I currently see:

  • with the flag: maybe not every replanner can support both behaviors, so we would be adding a flag in the replanner interface that might not work for some replanners (clashes with the idea 100% interchangeable engines)
  • without the flag: the default behavior is an exception, but if a replanner silently fails, we get the same issue of above

…ks and error_on_failed_checks to determine if a useless remove actually raises an error or not.
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 91.30% and project coverage change: +0.01% 🎉

Comparison is base (6d3cbec) 85.03% compared to head (d4c1db0) 85.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   85.03%   85.04%   +0.01%     
==========================================
  Files         198      198              
  Lines       26019    26042      +23     
==========================================
+ Hits        22125    22148      +23     
  Misses       3894     3894              
Files Changed Coverage Δ
unified_planning/engines/mixins/replanner.py 84.90% <ø> (ø)
unified_planning/engines/replanner.py 96.00% <87.50%> (+1.08%) ⬆️
unified_planning/test/test_replanner.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alvalentini alvalentini merged commit f7590a3 into master Sep 5, 2023
8 checks passed
@alvalentini alvalentini deleted the replanner-fix branch September 5, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants