Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible PDDL reading #475

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

More flexible PDDL reading #475

wants to merge 12 commits into from

Conversation

Framba-Luca
Copy link
Contributor

No description provided.

@Framba-Luca Framba-Luca self-assigned this Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 97.00% and project coverage change: +0.02% 🎉

Comparison is base (02f25aa) 84.98% compared to head (04dd805) 85.01%.
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   84.98%   85.01%   +0.02%     
==========================================
  Files         198      199       +1     
  Lines       26006    26091      +85     
==========================================
+ Hits        22102    22182      +80     
- Misses       3904     3909       +5     
Files Changed Coverage Δ
unified_planning/io/pddl_grammar.py 95.32% <95.32%> (ø)
unified_planning/io/pddl_reader.py 78.40% <100.00%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Framba-Luca Framba-Luca changed the title Interchangable order of functions and predicates in reading More flexible PDDL reading Sep 8, 2023
Copy link
Member

@mikand mikand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Framba-Luca please try the proposed suggestions. Also see if recycling the nextedExpr object makes any change in performance

unified_planning/io/pddl_grammar.py Show resolved Hide resolved
unified_planning/io/pddl_grammar.py Outdated Show resolved Hide resolved
unified_planning/io/pddl_reader.py Outdated Show resolved Hide resolved
@mikand mikand mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants