Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: various improvements to documentation #550

Merged
merged 4 commits into from
Dec 22, 2023
Merged

doc: various improvements to documentation #550

merged 4 commits into from
Dec 22, 2023

Conversation

arbimo
Copy link
Member

@arbimo arbimo commented Dec 15, 2023

This provides several minor improvements to the documentation. It mostly polishes and fixes some minor things.

A notable changes is regarding the "Optimality" documentation that now refers to ANytime planning and suggest using it when no optimality guarantee is needed.

The other important change is to the contributors guide that is now much more complete.

The most controversial thing is the addition of a justfile at the root of the repository that should aim at documenting, making discoverable and easily accessible the various commands taht are useful to interact with the code base.
just is command line utility that you can think of as a much better make. If you haven't used it I strongly suggest giving it a try.
Even without using it the justfile is useful in centralizing the different commands (without going into the CI configuration as I usually have to do).

The objective of the PR is not to generalize the usage of just but if there is consensus that it is a desirable thing it could be be extended (e.g. for running the tests) and used in CI to avoid duplication.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01c4614) 84.96% compared to head (8bc0b6b) 84.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         200      200           
  Lines       26433    26433           
=======================================
  Hits        22458    22458           
  Misses       3975     3975           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikand mikand requested review from mikand and removed request for alvalentini December 22, 2023 10:13
Copy link
Member

@mikand mikand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

You can use it to find out common commands (e.g. running tests, reformatting the code) or use it directly with the `just <https://github.com/casey/just>`_ command line tool.

Whenever you see a command ``just RECIPE_NAME`` in this page, it means the command is available as a just recipe.
You can run it directly with ``just`` or check the ``justfile`` for the actual commands to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I did not know just, I was missing out!

@mikand mikand merged commit da5bc97 into master Dec 22, 2023
8 checks passed
@mikand mikand deleted the doc-polishing branch December 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants