Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding continuous effects to durative actions #563

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

Alelafar
Copy link
Contributor

I added the decrease_continuous_effect and increase_continuous_effect functions in order to have a continuous change effect in a durative action and I added them also as two new ProblemKind.

Moreover, I suitably modified the PDDL Writer in order to dump the new tool to the PDDL domain.

@Alelafar Alelafar marked this pull request as ready for review January 25, 2024 16:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 89.97429% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (c9bb278) to head (e3813bf).
Report is 3 commits behind head on master.

Files Patch % Lines
unified_planning/io/pddl_reader.py 61.01% 23 Missing ⚠️
unified_planning/model/action.py 76.92% 9 Missing ⚠️
unified_planning/model/effect.py 66.66% 4 Missing ⚠️
unified_planning/io/pddl_writer.py 96.22% 2 Missing ⚠️
unified_planning/model/problem.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   85.19%   85.23%   +0.04%     
==========================================
  Files         201      201              
  Lines       27138    27451     +313     
==========================================
+ Hits        23120    23398     +278     
- Misses       4018     4053      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alelafar Alelafar force-pushed the Adding-continuous-effects-to-durative-actions branch from 1171d48 to da58f4c Compare March 14, 2024 14:37
…_increase function. But still need modifications
@Alelafar Alelafar force-pushed the Adding-continuous-effects-to-durative-actions branch from dd3b492 to 31dca0a Compare April 15, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants