Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Pull Request - 260123 #564

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

miquelramirez
Copy link
Contributor

Hello,

this PR fixes a typo and suggests a code example for the PDDL reader parser/factory that provides more handholding. I have also ported a piece of code in Python 2.x to Python 3.1x to use the newest string formatting capabilities in the notebook for the Temporal Planning example.

Thank you and congratulations for making all the way to 1.0.0.

 - Fun typo: "just to porsche" -> "just to parse"
 - Added `code-block` with code for PDDL reader example that shows the import the user needs to do.
 - Temporal planning notebook: ported code fragment aiplan4eu#9 from Python 2.0 to Python 3.1x
@miquelramirez miquelramirez changed the title Docs pr 260123 Docs Pull Request - 260123 Jan 26, 2024
Copy link
Member

@alvalentini alvalentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a comment to suggest you a different way to achieve the same result.

docs/interoperability.rst Outdated Show resolved Hide resolved
 - Changed back to `literalinclude::` following @avalentini suggestion of using the x,y-z notation for line referencing
 - Fixed copy & paste error
@alvalentini alvalentini merged commit 2dd252b into aiplan4eu:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants