logging in the right way

airaria · Jul 7, 2020 · 153be24 · 153be24
1 parent cdb8d12
commit 153be24
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 58 deletions.
diff --git a/examples/cmrc2018_example/main.distill.py b/examples/cmrc2018_example/main.distill.py
@@ -1,11 +1,10 @@
 import logging
+logging.basicConfig(
+    format='%(asctime)s - %(levelname)s - %(name)s -  %(message)s',
+    datefmt='%Y/%m/%d %H:%M:%S',
+    level=logging.INFO,
+    )
 logger = logging.getLogger("Main")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
 
 import os,random
 import numpy as np

diff --git a/examples/cmrc2018_example/main.trainer.py b/examples/cmrc2018_example/main.trainer.py
@@ -1,11 +1,10 @@
 import logging
+logging.basicConfig(
+    format='%(asctime)s - %(levelname)s - %(name)s -  %(message)s',
+    datefmt='%Y/%m/%d %H:%M:%S',
+    level=logging.INFO,
+    )
 logger = logging.getLogger("Main")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
 
 import os,random
 import numpy as np

diff --git a/examples/cmrc2018_example/processing.py b/examples/cmrc2018_example/processing.py
@@ -9,13 +9,7 @@
 import math
 import config
 #from tokenization import spacy_parser
-logger = logging.getLogger(__name__)
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
+logger = logging.getLogger("processing")
 
 class SquadExample(object):
     """A single training/test example for simple sequence classification."""

diff --git a/examples/cmrc2018_example/train_eval.py b/examples/cmrc2018_example/train_eval.py
@@ -10,13 +10,7 @@
 import json
 import numpy as np
 
-logger = logging.getLogger("Train_eval")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
+logger = logging.getLogger("train_eval")
 
 
 def predict(model, eval_examples, eval_features, step, args):

diff --git a/examples/cmrc2018_example/utils.py b/examples/cmrc2018_example/utils.py
@@ -3,7 +3,6 @@
 import config
 import logging
 logger = logging.getLogger("utils")
-logger.setLevel(logging.INFO)
 
 def read_and_convert(fn,is_training,read_fn,convert_fn,do_lower_case):
     data_dirname, data_basename = os.path.split(fn)

diff --git a/examples/mnli_example/main.distill.py b/examples/mnli_example/main.distill.py
@@ -1,11 +1,10 @@
 import logging
+logging.basicConfig(
+    format='%(asctime)s - %(levelname)s - %(name)s -  %(message)s',
+    datefmt='%Y/%m/%d %H:%M:%S',
+    level=logging.INFO,
+    )
 logger = logging.getLogger("Main")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
 
 import os,random
 import numpy as np

diff --git a/examples/mnli_example/main.multiteacher.py b/examples/mnli_example/main.multiteacher.py
@@ -1,11 +1,10 @@
 import logging
+logging.basicConfig(
+    format='%(asctime)s - %(levelname)s - %(name)s -  %(message)s',
+    datefmt='%Y/%m/%d %H:%M:%S',
+    level=logging.INFO,
+    )
 logger = logging.getLogger("Main")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
 
 import os,random
 import numpy as np

diff --git a/examples/mnli_example/main.trainer.py b/examples/mnli_example/main.trainer.py
@@ -1,11 +1,10 @@
 import logging
+logging.basicConfig(
+    format='%(asctime)s - %(levelname)s - %(name)s -  %(message)s',
+    datefmt='%Y/%m/%d %H:%M:%S',
+    level=logging.INFO,
+    )
 logger = logging.getLogger("Main")
-logger.setLevel(logging.INFO)
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
 
 import os,random
 import numpy as np

diff --git a/src/textbrewer/distillation.py b/src/textbrewer/distillation.py
@@ -16,13 +16,7 @@
 from .compatibility import mask_dtype
 
 logger = logging.getLogger("Distillation")
-logger.setLevel(logging.INFO)
-
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
+#logger.setLevel(logging.INFO)
 
 class CustomMatch:
     def __init__(self, module_T, module_S, weight, loss,

diff --git a/src/textbrewer/distiller_utils.py b/src/textbrewer/distiller_utils.py
@@ -16,13 +16,13 @@
 from .compatibility import mask_dtype
 
 logger = logging.getLogger("Distillation")
-logger.setLevel(logging.INFO)
+#logger.setLevel(logging.INFO)
 
-handler_stream = logging.StreamHandler()
-handler_stream.setLevel(logging.INFO)
-formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
-handler_stream.setFormatter(formatter)
-logger.addHandler(handler_stream)
+#handler_stream = logging.StreamHandler()
+#handler_stream.setLevel(logging.INFO)
+#formatter = logging.Formatter(fmt='%(asctime)s - %(levelname)s - %(name)s -  %(message)s', datefmt='%Y/%m/%d %H:%M:%S')
+#handler_stream.setFormatter(formatter)
+#logger.addHandler(handler_stream)
 
 class CustomMatch:
     def __init__(self, module_T, module_S, weight, loss,