Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected Route Issue (Peer Review) #30

Closed
dhruv-y opened this issue Feb 13, 2020 · 0 comments
Closed

Protected Route Issue (Peer Review) #30

dhruv-y opened this issue Feb 13, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@dhruv-y
Copy link

dhruv-y commented Feb 13, 2020

I tried testing your protected route (/home) which is accessed only after the user logs in, however, if I type the route in my URL it gives me an error. A possible fix for this would be to set a flag to false if the user is not logged and if he tries to access /home without logging in (check flag value), he should be redirected to your login page.

image

@dhruv-y dhruv-y added the bug Something isn't working label Feb 13, 2020
suyashporedi added a commit that referenced this issue Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants