Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Use google java styleguide formatting #4

Merged
merged 1 commit into from
Mar 25, 2015

Conversation

felipecsl
Copy link
Contributor

@nwadams
Copy link
Contributor

nwadams commented Mar 19, 2015

do we have an internal java style pattern we follow at airbnb. If so We would probably want to be uniform with that.

@petzel
Copy link
Contributor

petzel commented Mar 22, 2015

I think we should align with Google's style guide.
Reasoning is that it will make the project easier to work with for outside contributors. @nwadams what do you think?

@felipecsl
Copy link
Contributor Author

Also to give some context, right now most Java open source libs seem to be using this codestyle, so sounds like we should stick to that, instead of whatever Airbnb uses internally, which is probably not relevant for open source purposes

@nwadams
Copy link
Contributor

nwadams commented Mar 23, 2015

I'm in. But before merging this can we investigate a way to do this without destroying blame history

@nwadams
Copy link
Contributor

nwadams commented Mar 23, 2015

If we can find a way lets do this to airbnb codebase too

@felipecsl
Copy link
Contributor Author

do you guys wanna do this? i guess we don't care much about blame history here, since we only have about a dozen files and 28 commits.

@petzel
Copy link
Contributor

petzel commented Mar 25, 2015

Yep let's do it
On Mar 24, 2015 8:42 PM, "Felipe Lima" notifications@github.com wrote:

do you guys wanna do this? i guess we don't care much about blame history
here, since we only have about a dozen files and 28 commits.


Reply to this email directly or view it on GitHub
#4 (comment).

felipecsl added a commit that referenced this pull request Mar 25, 2015
[Proposal] Use google java styleguide formatting
@felipecsl felipecsl merged commit 3ed4adb into master Mar 25, 2015
@felipecsl felipecsl deleted the felipe/styleguide branch March 31, 2015 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants