-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requestPermissions did not exist pre M #89
Conversation
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-2.5-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it 2.13
@@ -69,12 +68,15 @@ static boolean shouldShowRequestPermissionRationale(Activity activity, String... | |||
* | |||
* @param airMapInterface the callback interface if permission is granted. | |||
*/ | |||
@TargetApi(Build.VERSION_CODES.M) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you still need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, don't need this anymore, plus this was misleading as well..
👍 |
seeing as the library wasn't updated in a while, can we push an update with this? It is currently affecting my app and would be nice to update to the new version. |
@sreejithraman for sure. I'm cutting 1.3.5 now... |
@sreejithraman this has been released as version 1.4.0 |
@felipecsl perfect! thanks |
No description provided.