Ensure a sorted DeepLinkEntry registry #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 add logic to ensure a stable sorting result 2 move the doc generation after the sorting, so the doc is sorted This is important for us: with sorted outputs we could decide whether or not to trigger different downstream processes, so we can save time on build tasks, and commit verifications
felipecsl
approved these changes
Aug 30, 2017
|
@jingwei423 can you look into the checkstyle failures? I can merge after that's green! |
1 add logic to ensure a stable sorting result 2 move the doc generation after the sorting, so the doc is sorted This is important for us: with sorted outputs we could decide whether or not to trigger different downstream processes, so we can save time on build tasks, and commit verifications
|
@felipecsl thanks for the review! Can we have a new release soon? So we can update our internal tools to depend on this change. |
|
@felipecsl can we have a release for this? |
|
Sure, we'll get one out soon! |
|
v3.1.1 has been uploaded. It should be available soon |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 add logic to ensure a stable sorting result
2 move the doc generation after the sorting, so the doc is sorted
This is important for us: with sorted outputs we could decide whether
or not to trigger different downstream processes, so we can save time
on build tasks, and commit verifications