Fix issue with annotated Kotlin function that were not inside a class when using ksp #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat also wraps the case when the method is not in an annotated class in the ksp case. Added test for this usecase.
rossbacher
commented
Jun 30, 2021
| import androidx.room.compiler.processing.XMethodElement | ||
| import androidx.room.compiler.processing.XTypeElement | ||
| import java.net.MalformedURLException | ||
|
|
||
| sealed class DeepLinkAnnotatedElement @Throws(MalformedURLException::class) constructor( | ||
| val uri: String, | ||
| val element: XElement, | ||
| val annotatedClass: XTypeElement | ||
| val annotatedClass: XMemberContainer |
There was a problem hiding this comment.
This is the main fix.
BenSchwab
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make DeepLinkAnnotatedElement.annotatedClass an XMemberContainer as that also wraps the case when the method is not in an annotated class in the ksp case.
Added test for this usecase.