Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic hashable and equatable conformances #92

Merged
merged 1 commit into from Apr 13, 2021

Conversation

bryankeller
Copy link
Contributor

Details

This removes the manual Equatable implementations and adds automatic Hashable conformances for public types. I imagine some people will find these automatic conformances useful in their feature code (Airbnb, for example 馃槅)

Related Issue

N/A

Motivation and Context

  • Remove error-prone manual Equatable conformances
  • Having them be Hashable means people's feature code can store these types in sets and dictionaries, or as properties in other Hashable / Equatable types

How Has This Been Tested

Made sure the Example app built and ran correctly

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the enhancement New feature or request label Apr 13, 2021
@bryankeller bryankeller merged commit 3073c0f into master Apr 13, 2021
@bryankeller bryankeller deleted the bk/add-automatic-hashable-conformance branch April 13, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants