Use buildconfig to get if we are running ksp or not

airbnb · Sep 4, 2022 · fbf680a · fbf680a
1 parent 84315b7
commit fbf680a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 15 deletions.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -56,7 +56,7 @@ jobs:
           api-level: ${{ matrix.api-level }}
           target: ${{ matrix.target }}
           arch: x86_64
-          script: ./gradlew connectedCheck --no-daemon --stacktrace -PuseKsp=false -DuseKsp=false
+          script: ./gradlew connectedCheck --no-daemon --stacktrace -PuseKsp=false
 
       - name: Run UI Tests w/ KSP
         uses: reactivecircus/android-emulator-runner@v2
@@ -65,7 +65,7 @@ jobs:
           api-level: ${{ matrix.api-level }}
           target: ${{ matrix.target }}
           arch: x86_64
-          script: ./gradlew connectedCheck --no-daemon --stacktrace -PuseKsp=true -DuseKsp=true
+          script: ./gradlew connectedCheck --no-daemon --stacktrace -PuseKsp=true
 
       - name: Run Screenshot Tests
         uses: reactivecircus/android-emulator-runner@v2

diff --git a/showkase-browser-testing/build.gradle b/showkase-browser-testing/build.gradle
@@ -20,6 +20,7 @@ android {
         exclude 'META-INF/gradle/incremental.annotation.processors'
         exclude("META-INF/*.kotlin_module")
     }
+
     defaultConfig {
         minSdkVersion 26
         targetSdkVersion 32
@@ -28,6 +29,12 @@ android {
         // "pm clear" command after each test invocation. This command ensures
         // that the app's state is completely cleared between tests.
         testInstrumentationRunnerArguments clearPackageData: 'true'
+
+        if (project.hasProperty('useKsp')) {
+            buildConfigField "boolean", "IS_RUNNING_KSP", "true"
+        } else {
+            buildConfigField "boolean", "IS_RUNNING_KSP", "false"
+        }
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_11

diff --git a/...g/src/androidTest/java/com/airbnb/android/showkase_browser_testing/ShowkaseBrowserTest.kt b/...g/src/androidTest/java/com/airbnb/android/showkase_browser_testing/ShowkaseBrowserTest.kt
@@ -6,7 +6,6 @@ import androidx.test.ext.junit.rules.ActivityScenarioRule
 import androidx.test.platform.app.InstrumentationRegistry
 import com.airbnb.android.showkase.models.Showkase
 import com.airbnb.android.showkase.ui.ShowkaseBrowserActivity
-import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -41,17 +40,12 @@ class ShowcaseBrowserTest {
     // beyond the source retention KEEP, except for in the new IR backend which was introduced
     // in Kotlin 1.6. It will be available in the old backend in Kotlin version 1.7.20.
     // See https://youtrack.jetbrains.com/issue/KT-49682 for more information about this.
-    private val componentSize = if (System.getProperty("useKsp") == "true") {
+    private val componentSize = if (BuildConfig.IS_RUNNING_KSP) {
         11
     } else {
         7
     }
 
-    @Before
-    fun setupLog() {
-        println("Use KSP value = ${System.getProperty("useKsp")}")
-    }
-
     @Test
     fun activity_starts_and_all_the_showkase_ui_elements_are_visible_on_the_screen_and_clickable() {
         // Assert that all the categories are displayed on the screen and that they are clickable.
@@ -92,7 +86,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Tap on the "Colors" row
             clickRowWithText("Colors (4)")
@@ -109,7 +104,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Tap on the "Typography" row
             clickRowWithText("Typography (13)")
@@ -193,7 +189,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Tap on the "Colors" row
             clickRowWithText("Colors (4)")
@@ -213,7 +210,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Tap on the "Typography" row
             clickRowWithText("Typography (13)")
@@ -242,7 +240,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Select Components
             clickRowWithText("Components ($componentSize)")
@@ -267,7 +266,8 @@ class ShowcaseBrowserTest {
             verifyLandingScreen(
                 components = componentSize,
                 typography = 13,
-                colors = 4,)
+                colors = 4,
+            )
 
             // Select Colors
             clickRowWithText("Colors (4)")