Update Compose to beta08 and Kotlin to 1.5.10 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
reviewed
Jun 3, 2021
...c/androidTest/java/com/airbnb/android/showkase_processor_testing/ShowkaseBrowserTestFlows.kt
Outdated
Show resolved
Hide resolved
vinaygaba
reviewed
Jun 3, 2021
| * assertIsNotDisplayed() fails if the node does not exist. | ||
| * See https://issuetracker.google.com/issues/187188981 | ||
| */ | ||
| private fun SemanticsNodeInteraction.assertEitherDoesNotExistOrIsNotDisplayed() { |
There was a problem hiding this comment.
is this related to a change introduced in beta08 or did I miss this from a previous release. Do you know the CL for this? Might be useful to add a link to that here.
There was a problem hiding this comment.
Seems it's actually since beta07 - and I'm guessing the failures I was seeing were probably actually caused by the "LazyColumn/Row will now keep up to 2 previously visible items active (not disposed)" part - https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.0.0-beta07
Tweaked the comment to point to that CL
vinaygaba
approved these changes
Jun 3, 2021
Had to use the new Card variant with an onClick listener, and work around some new LazyColumn semantics which were causing tests to fail Also replaced all newly deprecated toLower/UpperCase methods
benkay
force-pushed
the
kotlin-1.5-compose-beta08
branch
from
c974feb
to
08e9eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to use the new Card variant with an onClick listener, and work around some new LazyColumn semantics which were causing tests to fail
Also replaced all newly deprecated toLower/UpperCase methods