Fix duplicate class issue with generated metadata file #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the metadata file was simply taking the substring after the last '.' from the package name, it would cause issues if two different modules shared a common substring in their package names. Consider the following two modules -
If both were setup to use Showkase, Showkase would generate the following two files
In addition, both these files are added to a fixed package location -
com.airbnb.android.showkase
Thus, it would result in duplicate classes.
With the new changes, the entire package name is taken into account. This would help in avoiding this issue.
#198
@airbnb/showkase-maintainers