Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate class issue with generated metadata file #201

Merged
merged 4 commits into from Jan 4, 2022

Conversation

vinaygaba
Copy link
Collaborator

@vinaygaba vinaygaba commented Jan 4, 2022

Since the metadata file was simply taking the substring after the last '.' from the package name, it would cause issues if two different modules shared a common substring in their package names. Consider the following two modules -

module 1: com.jll.jet.qraccess.view
module 2: com.jll.jet.hid.view

If both were setup to use Showkase, Showkase would generate the following two files

module 1: ShowkaseMetadataView
module 2: ShowkaseMetadataView

In addition, both these files are added to a fixed package location - com.airbnb.android.showkase

Thus, it would result in duplicate classes.

With the new changes, the entire package name is taken into account. This would help in avoiding this issue.

#198

@airbnb/showkase-maintainers

@vinaygaba vinaygaba changed the title [DO NOT MERGE] Potential repro of a bug Fix duplicate class issue with generated metadata file Jan 4, 2022
@vinaygaba vinaygaba marked this pull request as ready for review January 4, 2022 02:02
@vinaygaba vinaygaba merged commit 794af71 into master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants