Remove redundant code in ShowkaseTheme.kt
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
reviewed
Jul 16, 2022
|
|
||
| @Composable | ||
| fun ShowkaseTheme(children: @Composable()() -> Unit) { |
There was a problem hiding this comment.
ha this rings a bell. Showkase was started when Compose was still in dev preview (back in April/May 2020). At the time, this syntax used to be needed 馃槄
There was a problem hiding this comment.
Aha! That makes sense! 馃槃
vinaygaba
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for an awesome library! I noticed that there was some redundant code in the
ShowkaseTheme.ktcode file, so I optimised it In this PR. 馃槃