Make multi-preview annotations not throw at compiletime #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
commented
Aug 22, 2022
showkase-processor/src/main/java/com/airbnb/android/showkase/processor/ShowkaseProcessor.kt
Outdated
Show resolved
Hide resolved
oas004
commented
Aug 22, 2022
...e-processor/src/main/java/com/airbnb/android/showkase/processor/logging/ShowkaseValidator.kt
Outdated
Show resolved
Hide resolved
|
cc @alexvanyo I'm working with Odin in getting Multi-preview support to Showkase. |
oas004
force-pushed
the
feature/make-multi-preview-not-crash
branch
from
9ff92b1
to
8095fdd
Compare
vinaygaba
reviewed
Aug 23, 2022
...e-processor/src/main/java/com/airbnb/android/showkase/processor/logging/ShowkaseValidator.kt
Outdated
Show resolved
Hide resolved
vinaygaba
reviewed
Aug 23, 2022
...e-processor/src/main/java/com/airbnb/android/showkase/processor/logging/ShowkaseValidator.kt
Outdated
Show resolved
Hide resolved
vinaygaba
reviewed
Aug 24, 2022
...cessorTest/composable_function_with_multiple_preview_functions_compiles/input/Composables.kt
Show resolved
Hide resolved
…rocessor/logging/ShowkaseValidator.kt Co-authored-by: Vinay Gaba <vinaygaba@gmail.com>
oas004
force-pushed
the
feature/make-multi-preview-not-crash
branch
from
6a27466
to
6af6b3c
Compare
vinaygaba
approved these changes
Aug 24, 2022
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in order for Showkase to support multi-preview annotations (annotations annotated with
@Preview)(#233)In this PR I have only made sure that consumers that are using multi-preview annotations can also use Showkase without compiletime failures. If the annotation processor faces such an issue, it will just skip it for now.
Leaving this as draft, as I have some questions about the validator function 😅