Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the IDE recognize generated code when using KSP #279

Merged
merged 3 commits into from Dec 16, 2022
Merged

Let the IDE recognize generated code when using KSP #279

merged 3 commits into from Dec 16, 2022

Conversation

Omico
Copy link
Contributor

@Omico Omico commented Nov 25, 2022

Fix #278, #265, #275
See also: https://kotlinlang.org/docs/ksp-quickstart.html#make-ide-aware-of-generated-code

Extra note for someone using android variants, you should use androidComponents.onVariants() instead.

Copy link
Collaborator

@vinaygaba vinaygaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omico Thanks for making this change. I had actually attempted to fix this here for some tests when I found a similar issue - https://github.com/airbnb/Showkase/blob/master/showkase-screenshot-testing-paparazzi-sample/build.gradle#L79

I didn't realize this was happening for all the cases. Can you also clean up the code I pointed to? After the changes you are adding, can you check what would still be needed in that file?

@Omico
Copy link
Contributor Author

Omico commented Dec 13, 2022

Hello @vinaygaba, I suggest migrating those Gradle files to Gradle KTS first.

Copy link
Collaborator

@vinaygaba vinaygaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showkase#getMetadata() is not generated
2 participants