Fix bug in getShowkaseMetadataFromPreview where the preview width was being set as the showkase metadata height #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
reviewed
Dec 5, 2022
| @@ -287,7 +287,7 @@ internal fun getShowkaseMetadataFromPreview( | |||
| showkaseName = showkaseName, | |||
| showkaseGroup = showkaseGroup, | |||
| showkaseWidthDp = if (width == -1) null else width, | |||
| showkaseHeightDp = if (height == -1) null else width, | |||
|
@stefankram seems like some tests are failing. Will you do a pass and fix them 🙏 |
|
@vinaygaba yep will take a look! |
… preview width was being set as the showkase metadata height
…ctly set in the generated showkase code
stefankram
force-pushed
the
bugfix/height_not_mapped_correctly_in_generated_code
branch
from
ca702b2
to
212963a
Compare
|
@vinaygaba this should be good to re-test |
|
Hey @vinaygaba I noticed a new version was created. I was hoping to get this PR merged and into that release... Is there anything else I can help with to get this merged down? |
|
@stefankram about to merge this! Just re-running the build |
vinaygaba
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for an issue I discovered when trying to get the height information of a
@Previewfrom aShowkaseBrowserComponent.Please let me know if I need to add any other tests to get this merged.