De-dupe with the fully qualified function name #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
reviewed
Apr 5, 2023
| if (it.componentIndex != null) { | ||
| "${it.showkaseName}_${it.showkaseGroup}_${it.showkaseStyleName}_${it.componentIndex}" | ||
| "${it.fqPrefix}_${it.showkaseName}_${it.showkaseGroup}_${it.showkaseStyleName}_${it.componentIndex}" |
There was a problem hiding this comment.
we already do the ${it.packageName}_${it.enclosingClassName}_${it.elementName} dedpuing above. Why do we need to do it again here 🤔
There was a problem hiding this comment.
@vinaygaba If I don't include it here as well it will remove ones that only differ by tags or extraMetadata. I tried to change this to do them in one distinctBy step but that messed up where a @Preview annotation has the same group/style as the @ShowkaseComposable annotation so I left it as two steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the fully qualified name (package + class name + function name) to the de-duplication strategy to support showkase components with the same group/component name/style name. This is useful when creating custom browsers where additional categorization is made via the new
tagsorextraMetadatafields that were added with #309.