This repository has been archived by the owner on May 20, 2021. It is now read-only.
[bugfix][cancel-query] Bugfixes and cancel query feature #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like good stuff to me. 👍 |
|
👍 but before merging, check my answer in #11 and let me know what you think! |
|
Addressed your comments in #11. |
andykram
added a commit
that referenced
this pull request
Dec 2, 2014
[bugfix][cancel-query] Bugfixes and cancel query feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
Bugfix
Features
DELETE /api/queries/:uuid@stefanvermaas: This PR implements the DELETE functionality I mentioned in #11. If we can come up with use cases for
PATCH, we can add that too./cc @stefanvermaas @airbnb/di