Register Module Binding

airbnb · Dec 28, 2019 · 266d26a · 266d26a
1 parent 759937b
commit 266d26a
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 6 deletions.
diff --git a/src/index.js b/src/index.js
@@ -28,7 +28,7 @@ export default declare(({
   }) => {
     const namedTemplate = `
       var SVG_NAME = function SVG_NAME(props) { return SVG_CODE; };
-      ${SVG_DEFAULT_PROPS_CODE ? 'SVG_NAME.defaultProps = SVG_DEFAULT_PROPS_CODE;' : ''}      
+      ${SVG_DEFAULT_PROPS_CODE ? 'SVG_NAME.defaultProps = SVG_DEFAULT_PROPS_CODE;' : ''}
       ${IS_EXPORT ? 'export { SVG_NAME };' : ''}
     `;
     const anonymousTemplate = `
@@ -44,7 +44,6 @@ export default declare(({
     return template(anonymousTemplate)({ SVG_CODE, SVG_DEFAULT_PROPS_CODE, EXPORT_FILENAME });
   };
 
-
   function applyPlugin(importIdentifier, importPath, path, state, isExport, exportFilename) {
     if (typeof importPath !== 'string') {
       throw new TypeError('`applyPlugin` `importPath` must be a string');
@@ -124,19 +123,22 @@ export default declare(({
   return {
     visitor: {
       Program: {
-        enter({ scope, node }, { file, opts, filename }) {
+        enter(path, { file, opts, filename }) {
           if (typeof filename === 'string' && typeof opts.filename !== 'undefined') {
             throw new TypeError('the "filename" option may only be provided when transforming code');
           }
           if (typeof filename === 'undefined' && typeof opts.filename !== 'string') {
             throw new TypeError('the "filename" option is required when transforming code');
           }
-          if (!scope.hasBinding('React')) {
+          if (!path.scope.hasBinding('React')) {
             const reactImportDeclaration = t.importDeclaration([
               t.importDefaultSpecifier(t.identifier('React')),
             ], t.stringLiteral('react'));
 
-            file.set('ensureReact', () => { node.body.unshift(reactImportDeclaration); });
+            file.set('ensureReact', () => {
+              const [newPath] = path.unshiftContainer('body', reactImportDeclaration);
+              newPath.get('specifiers').forEach((specifier) => { path.scope.registerBinding('module', specifier); });
+            });
           } else {
             file.set('ensureReact', () => {});
           }

diff --git a/test/fixtures/test-no-duplicate-react.jsx b/test/fixtures/test-no-duplicate-react.jsx
@@ -0,0 +1,5 @@
+import MySvg from './close.svg';
+
+export function MyFunctionIcon() {
+  return MySvg;
+}
diff --git a/test/sanity.js b/test/sanity.js
@@ -58,6 +58,30 @@ transformFile('test/fixtures/test-no-react.jsx', {
   validateDefaultProps(result);
 });
 
+transformFile('test/fixtures/test-no-duplicate-react.jsx', {
+  babelrc: false,
+  presets: ['@babel/preset-react'],
+  plugins: [
+    inlineReactSvgPlugin,
+    ({
+      visitor: {
+        Program: {
+          exit({ scope }) {
+            if (!scope.hasBinding('React')) {
+              throw new Error('React binding was expected.');
+            }
+          },
+        },
+      },
+    }),
+  ],
+}, (err, result) => {
+  if (err) throw err;
+  console.log('test/fixtures/test-no-duplicate-react.jsx', result.code);
+  assertReactImport(result);
+  validateDefaultProps(result);
+});
+
 if (fs.existsSync(path.resolve('./PACKAGE.JSON'))) {
   transformFile('test/fixtures/test-case-sensitive.jsx', {
     babelrc: false,
@@ -71,7 +95,7 @@ if (fs.existsSync(path.resolve('./PACKAGE.JSON'))) {
     if (err && err.message.indexOf('match case') !== -1) {
       console.log('test/fixtures/test-case-sensitive.jsx', 'Test passed: Expected case sensitive error was thrown');
     } else {
-      throw new Error('Test failed: Expected case sensitive error wasn‘t thrown, got: ' + err.message);
+      throw new Error(`Test failed: Expected case sensitive error wasn‘t thrown, got: ${err.message}`);
     }
   });
 } else {