Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds includePattern as options #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Himanshuub2
Copy link

adds includePattern as options , which is usefull when there are few paths that needs to be included instead of ignoring a lot of patterns.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do ignorePattern and includePattern interoperate? i'd assume if you want to un-ignore something you'd just negate that in the ignorePattern.

@@ -48,9 +49,18 @@ export default declare(({
if (typeof importPath !== 'string') {
throw new TypeError('`applyPlugin` `importPath` must be a string');
}
const { ignorePattern, caseSensitive, filename: providedFilename } = state.opts;
const {
ignorePattern, includePattern, caseSensitive, filename: providedFilename,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ignorePattern, includePattern, caseSensitive, filename: providedFilename,
ignorePattern,
includePattern,
caseSensitive,
filename: providedFilename,

:-) please don't use prettier on a repo that doesn't have it configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants