Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to babel 7 #48

Merged
merged 3 commits into from Oct 9, 2018
Merged

Upgrade to babel 7 #48

merged 3 commits into from Oct 9, 2018

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Sep 9, 2018

Fixes #41

Currently dependent on airbnb/babel-preset-airbnb#37 Shoutout to @vikr01 for that PR

/cc @ljharb

@stramel
Copy link
Contributor Author

stramel commented Sep 9, 2018

Removed Node v4,5 & 7 from Travis testing as they have reached End-of-life. https://github.com/nodejs/Release (Technically 9 has as well) This fixes the tests as Babel doesn't seem to support 4,5,7 anymore.

Not sure why the tests are failing... They were just passing locally and all were passing on the first commit except 4 & 5.

@vikr01
Copy link

vikr01 commented Sep 21, 2018

This might be due to ES6-style module-loading not fully working with babel-node.

Maybe try changing babel-node to node -r @babel/register in the test cases?

package.json Outdated
"@babel/core": "^7.0.0",
"@babel/node": "^7.0.0",
"@babel/preset-react": "^7.0.0",
"babel-preset-airbnb": "vikr01/babel-preset-airbnb#feature/babel-7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can't merge until we're using the actual package

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stramel this one's merged! airbnb/babel-preset-airbnb#37 thanks @ljharb

test/sanity.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Collaborator

ljharb commented Oct 1, 2018

@vikr01 that's just for the repl; it shouldn't be needed here

debugging diff

revert

revert preset

revert
@stramel stramel force-pushed the babel-7-upgrade branch 2 times, most recently from cae7ace to 4a075ae Compare October 1, 2018 21:26
@stramel
Copy link
Contributor Author

stramel commented Oct 9, 2018

@ljharb This should be ready to go now.

  • Updated to the official release of babel-preset-airbnb@^3.0.1
  • Tests are passing on Node 6,8,9,10
  • Lint is passing
  • Build is compiling
  • README.md has been updated.

@ljharb ljharb force-pushed the babel-7-upgrade branch 3 times, most recently from 516280d to 83cae6f Compare October 9, 2018 23:39
@ljharb ljharb merged commit cec0fff into airbnb:master Oct 9, 2018
@stramel stramel deleted the babel-7-upgrade branch October 9, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants